Unify all NVIC circuits for a single web-proof circuit #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a lunch break now but good progress so far on this. |
0xJepsen
changed the title
This doesn't make sense, we can't do this. We need to have separate circuits to fold! Happy to meet and explain this more if need be. |
|
Just FYI, this has a regression in circuit constraints. I was seeing roughly 1.2M constraints for AESGCTR for 320 bytes of plaintext. I have addressed this on a separate branch. |
|
Closing in favor of #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All circuits are accounted for. I added one missing test:
test/http/locker.test.ts. There are some tests that have been omitted because they rely on codegen. The tests and diffs not accounted for are here:The circuits/utils/array.circom and circuits/utils/bytes.circom utils are not missing anything but but do have some additional utilities that i added when i added the aes stuff.
Moving forward i will
Closes #19